Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Booleans handler like pluralization #767

Open
wants to merge 6 commits into
base: v8.x
Choose a base branch
from

Conversation

robinsondotnet
Copy link

This PR is related to the following issue: #722

@codecov-io
Copy link

Codecov Report

Merging #767 into v8.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             v8.x    #767      +/-   ##
=========================================
+ Coverage   96.26%   96.3%   +0.03%     
=========================================
  Files          10      10              
  Lines         803     811       +8     
=========================================
+ Hits          773     781       +8     
  Misses         30      30
Impacted Files Coverage Δ
src/extend.js 100% <100%> (ø) ⬆️
src/index.js 97.84% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb5269...6b90c38. Read the comment docs.

@kazupon
Copy link
Owner

kazupon commented Jan 16, 2020

@robinsondotnet
Thank you for your PR!
Could you write the docs, please?

@Soviut
Copy link

Soviut commented Aug 2, 2020

@robinsondotnet would you like me to write the documentation for this so that it can be merged?

@robinsondotnet
Copy link
Author

@robinsondotnet would you like me to write the documentation for this so that it can be merged?

@Soviut Sure. Thanks.

@DutchGerman
Copy link

What is the status on this PR? Is the documentation already written, could I help here?

@Soviut
Copy link

Soviut commented Feb 11, 2021

@DutchGerman I'm sorry, I don't think I ever received the notification for this back in August. I'll have to refamiliarize myself but I do want this to get merged.

@Soviut
Copy link

Soviut commented Feb 20, 2021

@robinsondotnet I've been working on the docs but will need to collaborate with you to contribute them to this PR. I've never had to contribute to a 3rd party PR before so I'm not sure if I need to be invited as a contributor to it or something?

@kazupon I've got most of the English documentation done, but I'm wondering what I need to do about the zh pages. For example, I've created a new /guide/boolean.md page, should I duplicate it in the /zh/guide directory and leave it as English until someone can translate it?

@robinsondotnet
Copy link
Author

robinsondotnet commented Feb 20, 2021

@Soviut Thanks! I have invited you as collaborator to robinsondotnet/vue-i18n in order to give you access to the branch is selected in this PR.

@vincenzomartusciello
Copy link

no eta to know when it will be merged?

@Soviut
Copy link

Soviut commented Sep 16, 2024

@robinsondotnet I fixed the merge conflict in the tests. This could be merged.

@Soviut
Copy link

Soviut commented Sep 16, 2024

@kazupon I'm not sure who I should be asking for final review and merge on this, so I'm pinging you.

@wolfgangwalther
Copy link

The last PR to be merged in this repo was in 2022, so don't expect too much.

@BobbieGoede
Copy link

Continued development on vue-i18n is on this repo https://github.com/intlify/vue-i18n, but it targets Vue 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants