Draft: Logs SDK, OTLP exporter #6
Draft
+2,999
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogRecord implements the read-write log record as described in the Logs SDK spec.
This is taken care of in the protobuf during OTLP export
* Pass the current Context to log record processors on emit * Access the current span within the current Context using OpenTelemetry::Trace.current_span * Reorganize attribute lists to match spec order
This was referenced May 8, 2024
Span context to context
Now that we instantiate log records in the logger provider, we can access the log_record_limits when we create a new log record. Pass the log_record_limits directly from the logger provider to the log record and apply the limits in the log record class.
…it-updates Log record processor with emit updates
Invalid attribute classes for keys and values will now emit an error message Also, the Internal.valid_key? and Internal.valid_value? methods are used for validation to align with Span attributes
Warning was emitted about constant being redefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an implementation of the OpenTelemetry Logs SDK and an OTLP exporter for Ruby. This implementation awaits review and approval from OTel Ruby maintainers/approvers.
The commits in this PR will be cherry-picked to become smaller PRs to keep this work easy to review.
Current PR under consideration: open-telemetry#1611
OpenTelemetry Logs SDK Specification
OpenTelemetry Spec Compliance Matrix - Logs
OpenTelemetry Ruby Logs Project Board