Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update message #60

Open
wants to merge 23 commits into
base: deletemekavilla
Choose a base branch
from
Open

Conversation

kavilla
Copy link
Owner

@kavilla kavilla commented Sep 27, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Utilizing the GitHub `workflow_dispatch`, we can trigger
a job with a specific input.

Here we are allowing for tests to be ran pulling down from:
https://github.com/opensearch-project/opensearch-dashboards-functional-test

This workflow uses the target branch of the PR to pull down
from the FTRepo and run the tests from that specific branch.

For example, PRs against `main` will pull down `main` from
the FTRepo.

The problem occurs when new functionality is opened or a bug is
fixed and, per industry standard, we want to see tests added
to ensure functionality, stability, and raise the bar.

But the cypress tests PR into the FTRepo depends on the new code
to be merged for the CI within the FTRepo to work. So we have a
stalemate that usually slows down PR review time.

Here, a manual run can be triggered using the branch provided by
the maintainer who ran the job.

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

[MANUAL CYPRESS TEST RUN RESULTS]

✅ Cypress test run succeeded!

Inputs:

Source repo: kavilla/OpenSearch-Dashboards-1
Source branch: Test repo: `kavilla/opensearch-dashboards-functional-test` Test branch:differentbranch``

Link to results:

https://github.com/kavilla/OpenSearch-Dashboards-1/actions/runs/6325414974

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla force-pushed the kavilla/ci/cypress_input_control branch from 9a12b56 to c76634a Compare September 27, 2023 10:23
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla closed this Sep 27, 2023
@kavilla kavilla force-pushed the kavilla/ci/cypress_input_control branch from c76634a to 41db465 Compare September 27, 2023 10:27
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla reopened this Sep 27, 2023
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant