Add aim and PV direction vectors, to support skeletons that have different joint orientations. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent joint orientations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first tried this plugin I had some trouble figuring out why it wasn't working on some skeletons. It turned out to be something simple: it assumes a particular joint orientation. flipOrientation will fix one particular case, but it wouldn't work in all cases.
I fixed this by adding vectors to specify the aim direction (the local vector from each joint to its child) and pole vector direction (the local vector from the elbow to the pole vector). The default values are (1,0,0) and (0,1,0), which should give the current behavior. flipOrientation is the same as (-1,0,0) and (0,-1,0). These vectors don't have to be axis-aligned.