Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading "\"" #11

Closed
wants to merge 5 commits into from
Closed

Conversation

jimmy-ungerman
Copy link

The code change removes the """ as desired. Here's the new output of the records endpoint:

  {
    "dnsName": "k8s.cname-prom.porkboi.io",
    "targets": [
      "heritage=external-dns,external-dns/owner=default,external-dns/resource=ingress/monitoring/prometheus-kube-prometheus-prometheus"
    ],
    "recordType": "TXT",
    "setIdentifier": "6650be64b2b8464db0d16ad6"
  },

However, we're still getting the error:

Skipping endpoint alertmanager.porkboi.io 0 IN CNAME 6650be64b2b8464db0d16ab2 porkboi.io [] because owner id does not match, found: \"\", required: \"default\""

Still think this is good to add though, makes the output look much cleaner.

@kashalls
Copy link
Owner

We actually tried removing the leading ", some test data from external-dns leads me to believe that this is required still. Is this working on your side?

@jimmy-ungerman
Copy link
Author

The endpoint works, and records are getting created, however the txt lookup still fails. I was thinking this still makes the output look cleaner

@buroa
Copy link
Contributor

buroa commented May 24, 2024

This isn't needed and is wrong.. I'll have the changes out soon.

@kashalls kashalls closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants