Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @karpathy this is such an awesome repo. I was implementing it from scratch using JAX and learned quite a bit :)
This PR proposes a more consistent naming convention.
n_embd
->embd_dim
, since we are really splitting theembd_dim
into separate heads, which have their ownhead_dim
C // self.n_head
->head_dim
to give a better namehs
->hd
, to unify naming from "head size" to "head dim", which connects nicely withembd_dm
att
->attn
for consistencytok_emb
->tok_embd
for consistency with usingembd
as an abbreviation forembedding
pos_emb
->pos_embd
for consistency with usingembd
as an abbreviation forembedding