Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hack): upgrade Trivy to v0.56.1 for consistency with CI #5710

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MAVRICK-1
Copy link
Contributor

@MAVRICK-1 MAVRICK-1 commented Oct 18, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Updated Trivy Version: Changed the version from v0.48.1 to v0.53.0 to ensure consistency across local usage and GitHub CI.

Which issue(s) this PR fixes:
Part of #5484 update hack/scan-image-vuln.sh

Special notes for your reviewer:

  • This change aligns the Trivy version used in the script with the version used in the CI workflow.

Does this PR introduce a user-facing change?

NONE

@karmada-bot
Copy link
Collaborator

@MAVRICK-1: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

  • Updated Trivy Version: Changed the version from v0.48.1 to v0.53.0 to ensure consistency across local usage and GitHub CI.

Which issue(s) this PR fixes:
Part of #5484 update hack/scan-image-vuln.sh

Special notes for your reviewer:

  • This change aligns the Trivy version used in the script with the version used in the CI workflow.

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.74%. Comparing base (ffbbe06) to head (cb16f59).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5710   +/-   ##
=======================================
  Coverage   39.74%   39.74%           
=======================================
  Files         650      650           
  Lines       55125    55125           
=======================================
+ Hits        21909    21910    +1     
  Misses      31807    31807           
+ Partials     1409     1408    -1     
Flag Coverage Δ
unittests 39.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @zhzhuang-zju

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2024
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2024
@RainbowMango
Copy link
Member

/hold

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2024
@RainbowMango
Copy link
Member

@MAVRICK-1 would you mind squashing the commits?

@MAVRICK-1
Copy link
Contributor Author

Okay 👍

@zhzhuang-zju
Copy link
Contributor

/retitle chore(hack): upgrade Trivy to v0.56.1 for consistency with CI

@karmada-bot karmada-bot changed the title chore(hack): upgrade Trivy to v0.53.0 for consistency with CI chore(hack): upgrade Trivy to v0.56.1 for consistency with CI Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants