Update types.go

[LavredisG]

/kind documentation

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.75%. Comparing base (201409c) to head (937d7c6).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5691   +/-   ##
=======================================
  Coverage   37.75%   37.75%           
=======================================
  Files         649      649           
  Lines       45133    45133           
=======================================
  Hits        17042    17042           
  Misses      26795    26795           
  Partials     1296     1296           

Flag	Coverage Δ
unittests	37.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RainbowMango]

/assign

[RainbowMango]

/lgtm

Thanks @LavredisG for doing this. It looks great!

But there is another file which has almost the same content that needs to be fixed, would you like the fix them as well?

By the way, if you touch the file linked above, you have to generate the file by following command:

make update

[LavredisG]

/lgtm

Thanks @LavredisG for doing this. It looks great!

But there is another file which has almost the same content that needs to be fixed, would you like the fix them as well?

By the way, if you touch the file linked above, you have to generate the file by following command:

make update

Once I find some time I will probably fix the other one too. Could you please explain a bit more about the "make update" command? I do these changes from github gui, but in order to change the linked file I should first fork the repo and work on it locally in order to then execute the command?

[RainbowMango]

Could you please explain a bit more about the "make update" command?

This is a Makefile command and it will run some scripts to generates other files.

I do these changes from github gui, but in order to change the linked file I should first fork the repo and work on it locally in order to then execute the command?

Yes, I think so. You need to fork it on your local machine and run the command above.
But don't worry, if you can't do that, I can help with the rest.

[karmada-bot]

New changes are detected. LGTM label has been removed.

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rainbowmango. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS
• pkg/apis/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[LavredisG]

Could you please explain a bit more about the "make update" command?

This is a Makefile command and it will run some scripts to generates other files.

I do these changes from github gui, but in order to change the linked file I should first fork the repo and work on it locally in order to then execute the command?

Yes, I think so. You need to fork it on your local machine and run the command above. But don't worry, if you can't do that, I can help with the rest.

After running the make update command I got many "unused parameter" warnings on zz_generated.openapi.go and many "APU Rule violation" while the command was running, is that expected?

[RainbowMango]

After running the make update command I got many "unused parameter" warnings on zz_generated.openapi.go and many "APU Rule violation" while the command was running, is that expected?

I don't find any unused parameter warnings on my side, but the API Rule violation warning can be ignored(I don't know why honestly, but the result is good).

As long as it ends without errors, it should be OK. Just reminder to commit all generated files.
I can see that one file(api/openapi-spec/swagger.json) is missing from this PR so far, everything else looks good.