-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hasResource should return whether resource is matched not cached #5662
base: master
Are you sure you want to change the base?
hasResource should return whether resource is matched not cached #5662
Conversation
d30991e
to
d6faa81
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5662 +/- ##
==========================================
+ Coverage 34.14% 38.25% +4.10%
==========================================
Files 643 649 +6
Lines 44522 45126 +604
==========================================
+ Hits 15204 17264 +2060
+ Misses 28162 26554 -1608
- Partials 1156 1308 +152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign |
Signed-off-by: huangyanfeng <[email protected]>
d6faa81
to
e7b6513
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/assign @ikaven1024
Hi @yanfeng1992, can you help add the release note? Maybe we need to cherry-pick this patch to the previous branch. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
For detailed information of in tree plugins' execution order, please see:
// https://github.com/karmada-io/karmada/tree/master/docs/proposals/resource-aggregation-proxy#request-routing
But in fact, I found that if the requested resource is defined in ResourceRegistry but there is no cluster, the query is the resource of the karmada apiserver
This will cause two problems
case1.When there is no cluster registered, the query resource comes from karmada-apiserver
case2.When using watch, after deleting all clusters, watch will fail
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: