Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg/util: unit test patcher #5652

Merged

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unit test the patcher in the karmada operator pkg on patching the Deployment and StatefulSet k8s manifests.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.08%. Comparing base (19b32a2) to head (5ef98ec).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5652      +/-   ##
==========================================
+ Coverage   39.02%   39.08%   +0.06%     
==========================================
  Files         650      650              
  Lines       45207    45207              
==========================================
+ Hits        17641    17671      +30     
+ Misses      26207    26175      -32     
- Partials     1359     1361       +2     
Flag Coverage Δ
unittests 39.08% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/cc @chaosi-zju

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
In this commit, we unit test the patcher in the karmada operator
pkg on patching the Deployment and StatefulSet K8S objects.

Signed-off-by: Mohamed Awnallah <[email protected]>
@mohamedawnallah
Copy link
Contributor Author

@XiShanYongYe-Chang It looks like this PR didn’t merge automatically after receiving lgtm. I recall that issue occurring before. I’ll rebase it and ask for review. :)

@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2024
@XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang It looks like this PR didn’t merge automatically after receiving lgtm. I recall that issue occurring before. I’ll rebase it and ask for review. :)

In addition to lgtm, the integration needs to be approved.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2024
@karmada-bot karmada-bot merged commit a96390e into karmada-io:master Oct 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants