-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/util: unit test patcher #5652
operator/pkg/util: unit test patcher #5652
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5652 +/- ##
==========================================
+ Coverage 39.02% 39.08% +0.06%
==========================================
Files 650 650
Lines 45207 45207
==========================================
+ Hits 17641 17671 +30
+ Misses 26207 26175 -32
- Partials 1359 1361 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ca03df1
to
63b1263
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/cc @chaosi-zju
In this commit, we unit test the patcher in the karmada operator pkg on patching the Deployment and StatefulSet K8S objects. Signed-off-by: Mohamed Awnallah <[email protected]>
@XiShanYongYe-Chang It looks like this PR didn’t merge automatically after receiving |
63b1263
to
5ef98ec
Compare
In addition to lgtm, the integration needs to be approved. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test the patcher in the karmada operator pkg on patching the Deployment and StatefulSet k8s manifests.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: