-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/tasks/init: unit test etcd #5634
base: master
Are you sure you want to change the base?
operator/pkg/tasks/init: unit test etcd #5634
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
63e6e87
to
8e85d98
Compare
In this commit, we unit test the etcd init task in the operator package on both deployment and waiting operations to become up and running. Signed-off-by: Mohamed Awnallah <[email protected]>
8e85d98
to
3ad71cd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5634 +/- ##
==========================================
+ Coverage 39.09% 39.30% +0.21%
==========================================
Files 650 650
Lines 45209 45209
==========================================
+ Hits 17676 17771 +95
+ Misses 26180 26071 -109
- Partials 1353 1367 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @XiShanYongYe-Chang All test cases passed after rebasing on the master branch :) |
Description
In this commit, we unit test the etcd init task in the operator package on both deployment and waiting operations to become up and running.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Dependency
This PR depends on #5630.
Does this PR introduce a user-facing change?: