Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add realted ut for migration rollback feature #5628

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wulemao
Copy link
Contributor

@wulemao wulemao commented Sep 30, 2024

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

add realted ut for migration rollback feature

Which issue(s) this PR fixes:

Fixes part of #5380

Special notes for your reviewer:

!!!need rebasing upon #5626, waiting for it to be merged

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Sep 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 6.08108% with 139 lines in your changes missing coverage. Please review.

Project coverage is 35.11%. Comparing base (eaa3452) to head (ba315a3).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
pkg/karmadactl/unregister/unregister.go 7.56% 110 Missing ⚠️
pkg/karmadactl/util/cluster.go 0.00% 22 Missing ⚠️
pkg/util/secret.go 0.00% 5 Missing ⚠️
pkg/karmadactl/karmadactl.go 0.00% 1 Missing ⚠️
pkg/karmadactl/unjoin/unjoin.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5628      +/-   ##
==========================================
+ Coverage   35.01%   35.11%   +0.10%     
==========================================
  Files         645      647       +2     
  Lines       44861    44994     +133     
==========================================
+ Hits        15708    15800      +92     
- Misses      27938    27963      +25     
- Partials     1215     1231      +16     
Flag Coverage Δ
unittests 35.11% <6.08%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wulemao wulemao changed the title add realted ut for migration rollback feature [WIP] add realted ut for migration rollback feature Sep 30, 2024
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants