Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e for migration rollback feature #5609

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wulemao
Copy link
Contributor

@wulemao wulemao commented Sep 26, 2024

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

add e2e for migration rollback feature

Which issue(s) this PR fixes:

Fixes part of #5577

Special notes for your reviewer:

contains a commit from #5597, waiting for it being merged and doing a rebase

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Sep 26, 2024
@wulemao wulemao changed the title Rollback e2e1 add e2e for migration rollback feature Sep 26, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2024
@wulemao
Copy link
Contributor Author

wulemao commented Sep 26, 2024

/hold waiting for #5597 be merged

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@chaosi-zju
Copy link
Member

I prefer to change the file name seamless_migration_test.go to migration_and_rollback_test.go since it now contains not only migration feature

Comment on lines +139 to +140
framework.WaitDeploymentPresentOnClusterFitWith(member1, deployment.Namespace, deployment.Name,
func(*appsv1.Deployment) bool { return true })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to #5597 (comment), we can add testing wthether the related labels is cleaned after rollback~

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 32.25806% with 42 lines in your changes missing coverage. Please review.

Project coverage is 35.24%. Comparing base (eaa3452) to head (0133c2d).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/detector/detector.go 0.00% 17 Missing ⚠️
pkg/controllers/execution/execution_controller.go 43.75% 7 Missing and 2 partials ⚠️
pkg/controllers/binding/common.go 27.27% 8 Missing ⚠️
pkg/util/helper/work.go 0.00% 2 Missing ⚠️
pkg/controllers/mcs/service_export_controller.go 0.00% 1 Missing ⚠️
...clusterservice/endpointslice_collect_controller.go 0.00% 1 Missing ⚠️
...lusterservice/endpointslice_dispatch_controller.go 0.00% 0 Missing and 1 partial ⚠️
.../controllers/multiclusterservice/mcs_controller.go 0.00% 0 Missing and 1 partial ⚠️
...controllers/namespace/namespace_sync_controller.go 0.00% 0 Missing and 1 partial ⚠️
...controllers/unifiedauth/unified_auth_controller.go 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5609      +/-   ##
==========================================
+ Coverage   35.01%   35.24%   +0.22%     
==========================================
  Files         645      646       +1     
  Lines       44861    44891      +30     
==========================================
+ Hits        15708    15820     +112     
+ Misses      27938    27836     -102     
- Partials     1215     1235      +20     
Flag Coverage Δ
unittests 35.24% <32.25%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a7i
Copy link
Contributor

a7i commented Oct 17, 2024

@wulemao thanks for your patience, would you please rebase since the PR was merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants