-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e for migration rollback feature #5609
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Amir Alavi <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold waiting for #5597 be merged |
I prefer to change the file name |
framework.WaitDeploymentPresentOnClusterFitWith(member1, deployment.Namespace, deployment.Name, | ||
func(*appsv1.Deployment) bool { return true }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to #5597 (comment), we can add testing wthether the related labels is cleaned after rollback~
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5609 +/- ##
==========================================
+ Coverage 35.01% 35.24% +0.22%
==========================================
Files 645 646 +1
Lines 44861 44891 +30
==========================================
+ Hits 15708 15820 +112
+ Misses 27938 27836 -102
- Partials 1215 1235 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cebedf8
to
bf3f414
Compare
Signed-off-by: wulemao <[email protected]>
bf3f414
to
0133c2d
Compare
@wulemao thanks for your patience, would you please rebase since the PR was merged? |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
add e2e for migration rollback feature
Which issue(s) this PR fixes:
Fixes part of #5577
Special notes for your reviewer:
contains a commit from #5597, waiting for it being merged and doing a rebase
Does this PR introduce a user-facing change?: