-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/karmadaresource: unit test RBAC #5603
operator/pkg/karmadaresource: unit test RBAC #5603
Conversation
In this commit, we add unit tests for the RBAC in the karamada resource operator pkg making sure Karmada Resource View Clusterrole and Karmada Resource Edit Clusterrole are working as expected. Signed-off-by: Mohamed Awnallah <[email protected]>
80be809
to
f74dbb0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5603 +/- ##
==========================================
+ Coverage 39.02% 39.07% +0.05%
==========================================
Files 650 650
Lines 45207 45207
==========================================
+ Hits 17641 17664 +23
+ Misses 26207 26175 -32
- Partials 1359 1368 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @XiShanYongYe-Chang All tests cases passed now after rebasing :) |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we add unit tests for the RBAC in the karamada resource operator pkg making sure Karmada Resource View Clusterrole and Karmada Resource Edit Clusterrole are working as expected.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: