Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/pkg/karmadaresource/apiservice: unit test apiservice #5596

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Sep 23, 2024

Description

In this commit, we unit test the api service in the karmada resource operator pkg.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Dependency
This PR depends on #5602.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 23, 2024
@mohamedawnallah mohamedawnallah force-pushed the unitTestAPIServiceKarmadaResourceOperatorPkg branch from 239e2c1 to d54cc52 Compare September 25, 2024 08:48
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2024
@mohamedawnallah mohamedawnallah force-pushed the unitTestAPIServiceKarmadaResourceOperatorPkg branch from d54cc52 to 96df3dc Compare September 25, 2024 08:50
@mohamedawnallah mohamedawnallah changed the title operator/pkg/karmadaresource/apiservice: unit test apiservice [WIP] operator/pkg/karmadaresource/apiservice: unit test apiservice Sep 25, 2024
Signed-off-by: Mohamed Awnallah <[email protected]>
@mohamedawnallah mohamedawnallah force-pushed the unitTestAPIServiceKarmadaResourceOperatorPkg branch from 96df3dc to 1474463 Compare October 17, 2024 16:28
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.67%. Comparing base (0d55ead) to head (1474463).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5596      +/-   ##
==========================================
- Coverage   39.09%   38.67%   -0.43%     
==========================================
  Files         650      650              
  Lines       45209    55125    +9916     
==========================================
+ Hits        17676    21317    +3641     
- Misses      26180    32436    +6256     
- Partials     1353     1372      +19     
Flag Coverage Δ
unittests 38.67% <ø> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah
Copy link
Contributor Author

cc @XiShanYongYe-Chang All test cases passed after rebasing on the master branch :)

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@karmada-bot karmada-bot merged commit 1a958e2 into karmada-io:master Oct 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants