-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/pkg/karmadaresource/apiservice: unit test apiservice #5596
operator/pkg/karmadaresource/apiservice: unit test apiservice #5596
Conversation
239e2c1
to
d54cc52
Compare
d54cc52
to
96df3dc
Compare
Signed-off-by: Mohamed Awnallah <[email protected]>
96df3dc
to
1474463
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5596 +/- ##
==========================================
- Coverage 39.09% 38.67% -0.43%
==========================================
Files 650 650
Lines 45209 55125 +9916
==========================================
+ Hits 17676 21317 +3641
- Misses 26180 32436 +6256
- Partials 1353 1372 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @XiShanYongYe-Chang All test cases passed after rebasing on the master branch :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test the api service in the karmada resource operator pkg.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Dependency
This PR depends on #5602.
Does this PR introduce a user-facing change?: