Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator/pkg/certs: unit test Certificate Manager and Karmada Store #5559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

operator/pkg/certs: unit test Certificate Manager and Karmada Store #5559

wants to merge 1 commit into from
+991 −0

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Sep 16, 2024 •
edited
Loading

Description

In this commit, we introduce unit tests for operator certs package. The test cases include but not limited to:

  • Test private key generation.
  • Test self-signed certificate authority (CA) generation.
  • Verify creation of self-signed certificate and key files within the CA.
  • Include tests for utility functions, such as appending to Subject Alternative Names in SSL/TLS certificates.
  • Add tests for Karmada Store operations related to certificates stored in Kubernetes Secrets:
    • Create
    • Read
    • Update
    • Load

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Dependency
This PR depends on #5560 and #5561.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 16, 2024
@mohamedawnallah mohamedawnallah mentioned this pull request Sep 16, 2024
Open
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 16, 2024
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 16, 2024
This was referenced Sep 16, 2024
Merged
Merged
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 40.09%. Comparing base (31bc022) to head (a83c26e).

Files with missing lines Patch % Lines
operator/pkg/util/util.go 0.00% 22 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5559      +/-   ##
==========================================
+ Coverage   39.73%   40.09%   +0.35%     
==========================================
  Files         650      650              
  Lines       55171    55193      +22     
==========================================
+ Hits        21922    22128     +206     
+ Misses      31840    31643     -197     
- Partials     1409     1422      +13
Flag Coverage Δ
unittests 40.09% <0.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah
operator/pkg/certs: test certs
a83c26e 
In this commit, we introduce unit tests for operator `certs` package.
The test cases include but not limited to:

- Test private key generation.
- Test self-signed certificate authority (CA) generation.
- Verify creation of self-signed certificate and key files within the CA.
- Include tests for utility functions, such as appending to Subject Alternative Names in SSL/TLS certificates.
- Add tests for Karmada Store operations related to certificates stored in Kubernetes Secrets:
  - Create
  - Read
  - Update
  - Load

Signed-off-by: Mohamed Awnallah <[email protected]>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign calvin0327 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 19, 2024
@mohamedawnallah
Copy link
Contributor Author

cc @XiShanYongYe-Chang All test cases passed after PR #5561 was merged and rebasing on master branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvin0327 calvin0327 Awaiting requested review from calvin0327

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohamedawnallah @codecov-commenter @karmada-bot