-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced forced deletion on karmadactl unjoin #4451
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4451 +/- ##
==========================================
+ Coverage 37.99% 38.17% +0.18%
==========================================
Files 649 649
Lines 45133 45179 +46
==========================================
+ Hits 17148 17248 +100
+ Misses 26688 26623 -65
- Partials 1297 1308 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This request I think is reasonable, but I don't think just deleting the cluster can solve it, it should also forcibly delete the work
under this cluster. It should also forcibly delete other resources like token
,secret
,etc.
In fact, I achieve the purpose of forced deletion by deleting the |
The issue can be resolved by setting |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Apologies for the confusion between the two scenarios earlier. |
Signed-off-by: zhzhuang-zju <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
When karmadactl unjoin a member cluster, the unjoin may fail all the time because the resource deletion of the member cluster fails. By enhancing the forced deletion on karmadactl unjoin, if the resource deletion of the member cluster fails also force unjoin
Which issue(s) this PR fixes:
Fixes #4431
Special notes for your reviewer:
➜ karmada git:(master) km1 delete clusterrole karmada-controller-manager:karmada-member1 clusterrole.rbac.authorization.k8s.io "karmada-controller-manager:karmada-member1" deleted
Does this PR introduce a user-facing change?: