operator/pkg/certs: fix null ptr deref in altnames

In this commit, we fix th null pointer dereference issue that happens in altnames mutators for both Karmada APIServer and EtcdServer when accessing the `Components` field on `AltNamesMutatorConfig` struct. Signed-off-by: Mohamed Awnallah <[email protected]>
karmada-io · Sep 16, 2024 · 89794f1 · 89794f1
1 parent 671372a
commit 89794f1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/operator/pkg/certs/certs.go b/operator/pkg/certs/certs.go
@@ -455,7 +455,7 @@ func etcdServerAltNamesMutator(cfg *AltNamesMutatorConfig) (*certutil.AltNames,
 		IPs:      []net.IP{net.IPv4(127, 0, 0, 1)},
 	}
 
-	if cfg.Components.Etcd.Local != nil {
+	if cfg.Components != nil && cfg.Components.Etcd != nil && cfg.Components.Etcd.Local != nil {
 		appendSANsToAltNames(altNames, cfg.Components.Etcd.Local.ServerCertSANs)
 	}
 
@@ -488,7 +488,7 @@ func apiServerAltNamesMutator(cfg *AltNamesMutatorConfig) (*certutil.AltNames, e
 			fmt.Sprintf("*.%s.svc", cfg.Namespace)})
 	}
 
-	if len(cfg.Components.KarmadaAPIServer.CertSANs) > 0 {
+	if cfg.Components != nil && cfg.Components.KarmadaAPIServer != nil && len(cfg.Components.KarmadaAPIServer.CertSANs) > 0 {
 		appendSANsToAltNames(altNames, cfg.Components.KarmadaAPIServer.CertSANs)
 	}
 	if len(cfg.ControlplaneAddress) > 0 {