-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Jasmine 5 #333
Comments
I maintain Jasmine, but I'm not involved in Karma development and I don't speak for the Karma team. Based on the deprecation notice, I would not expect to see a karma-jasmine release that supports Jasmine 5.0. However, I don't see anything in the karma-jasmine codebase that would run afoul of any of the breaking changes in 5.0. So using an NPM override to make karma-jasmine use jasmine-core 5 should work fine. |
I've created a PR: #337 |
Since Karma is deprecated, there's not going to be an update for karma-jasmine. An override is the only way to upgrade until the migration to the Jasmine web runner (which - according to the deprecation annoncement - possibly requires an Angular update). Workaround from karma-runner/karma-jasmine#333.
* Bump @types/jasmine from 4.3.6 to 5.1.4 Bumps [@types/jasmine](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jasmine) from 4.3.6 to 5.1.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jasmine) --- updated-dependencies: - dependency-name: "@types/jasmine" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bumped prettier and puppeteer * Fixed file formatting for prettier v3.2.5 * Updated CircleCI orbs and added missing npm install step. * Added override to enable using Jasmine 5. Since Karma is deprecated, there's not going to be an update for karma-jasmine. An override is the only way to upgrade until the migration to the Jasmine web runner (which - according to the deprecation annoncement - possibly requires an Angular update). Workaround from karma-runner/karma-jasmine#333. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shir Bar Lev <[email protected]>
Since Karma is deprecated, there's not going to be an update for karma-jasmine. An override is the only way to upgrade until the migration to the Jasmine web runner (which - according to the deprecation annoncement - possibly requires an Angular update). Workaround from karma-runner/karma-jasmine#333.
Since Karma is deprecated, there's not going to be an update for karma-jasmine. An override is the only way to upgrade until the migration to the Jasmine web runner (which - according to the deprecation annoncement - possibly requires an Angular update). Workaround from karma-runner/karma-jasmine#333.
Hello @jginsburgn,
Do you think it would be possible to support Jasmine 5 ?
I don't know if bumping the version to
"jasmine-core": "^4.1.0 | ^5.0.0"
would be enough.Have a good day.
The text was updated successfully, but these errors were encountered: