Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jasmine 5 #74

Closed
Yberion opened this issue May 15, 2023 · 1 comment
Closed

Support Jasmine 5 #74

Yberion opened this issue May 15, 2023 · 1 comment

Comments

@Yberion
Copy link

Yberion commented May 15, 2023

Hello @dfederm,

Do you think it would be possible to support Jasmine 5 ?

I don't know if bumping the version to "jasmine-core": "^4.0.0 | ^5.0.0" would be enough.
I think it would require an updated version of karma-jasmine as well, I've made a ticket for that karma-runner/karma-jasmine#333.

Have a good day.

@dfederm
Copy link
Owner

dfederm commented Jun 5, 2023

This is done as of 2.1.0.

Note that because karma-jasmine still depends on jasmine-core ^4.1.0, you may also need this in your package.json:

  "overrides": {
    "karma-jasmine": {
      "jasmine-core": "^4.1.0 || ^5.0.0"
    }
  }

At least I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants