Allow legacy VaultKV configuration keys in kapitan.secrets.vaultkv
#1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry config fields This ensures that existing Kapitan inventories which configure the VaultKV refs backend through the inventory (`kapitan.secrets.vaultkv`) using the currently documented approach (see https://kapitan.dev/latest/references/?h=vaultkv#vaultkv) which uses envvar style keys to configure some Vault connection details. Note that with the explicit aliases, the `env_prefix` setting has no effect, so we remove it.
simu
force-pushed
the
legacy-vaultkv-config-validation
branch
2 times, most recently
from
824a9c0
to
77af251
Compare
|
Behavior which causes the validation error when providing |
…vvar Setting `VAULT_ADDR` for `kapitan refs --reveal` for a VaultKV secret causes a validation error due to the way we implement support for legacy envvar style vaultkv configurations in the inventory.
simu
force-pushed
the
legacy-vaultkv-config-validation
branch
from
77af251
to
99ebe2b
Compare
ademariag
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
TODO
VAULT_ADDRand initializer fieldaddrwill cause a validation error unlessextrais set toignoreorallowneither of which have the desired effect of protecting users against config errors in the inventory.Docs and Tests