Fix fetch_git_dependency() to clobber files in the destination if force_fetch=True
#1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
changed the title
force_fetch=Truefetch_git_dependency() to clobber files in the destination if force_fetch=True
simu
force-pushed
the
fix/fetch-git-dependency-force
branch
4 times, most recently
from
27ee150
to
e3584df
Compare
ademariag
reviewed
Sep 4, 2024
…force_fetch=True` When force fetching Git dependencies, we need to be able to overwrite read-only files in the destination, since Git repos may contain read-only pack and index files in `.git/`. To do so, this commit introduces flag `clobber_files` for `utils.copy_tree()` which will completely clobber existing files in the destination by setting a custom `copy_function` for `shutil.copytree()` which deletes existing destination files before copying them with `shutil.copy2()`. With this change, `utils.copy_tree()` with `clobber_files=True` behaves pretty much identically to distutils' `copy_tree()` which was used in previous versions of Kapitan.
simu
force-pushed
the
fix/fetch-git-dependency-force
branch
from
e3584df
to
3f3e20c
Compare
ademariag
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When force fetching Git dependencies, we need to be able to overwrite read-only files in the destination, since Git repos may contain read-only pack and index files in
.git/.To do so, this PR introduces flag
clobber_filesforutils.copy_tree()which will completely clobber existing files in thedestination by setting a custom
copy_functionforshutil.copytree()which deletes existing destination files before copying them withshutil.copy2().With this change,
utils.copy_tree()withclobber_files=Truebehaves pretty much identically to distutils'copy_tree()which was used in previous versions of Kapitan.TODO
utils.copy_tree()to createdstif it doesn't exist #1231 is mergedDocs and Tests