Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reclass-rs considered optional by pip and friends #1211

Conversation

antonincms
Copy link
Contributor

It seems the reason is that it was mentioned in tool.poetry.extras.

Fixes #1210

Proposed Changes

Remove reclass-rs from extras to fix pip / pipx / uv not installing it.

Docs and Tests

  • Tests added
  • Updated documentation

It seems the reason is that it was mentioned in tool.poetry.extras.
@antonincms antonincms force-pushed the feature/fix-reclass-rs-not-installed branch from a629e89 to 2a29440 Compare August 30, 2024 11:47
@ademariag
Copy link
Contributor

Hi @antonincms, I think I prefer #1213 because it allows us to keep reclass-rs and omegaconf optional, to reduce package size

@ademariag ademariag closed this Aug 31, 2024
@antonincms antonincms deleted the feature/fix-reclass-rs-not-installed branch October 28, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: kapitan v0.34.0-rc.0 pip and friends does not install required dependency reclass_rs
2 participants