Nexenio/overhaul vault pr

[ademariag]

Fixes for PR #958

Proposed Changes

• improves tests

[MatteoVoges]

Thanks. It looks like everything made it into the PR. There are some newer modifications in nexenio-dev, but for now this is fine and is ready to get integrated!

[MatteoVoges]

Do you know whats up with the tests? I will probably investigate it tomorrow

[MatteoVoges]

Hey @ademariag , I tried fixing the tests already but there is some issue with the container. We tried a basic script in github actions, with just starting the container und trying to curl it, and even that fails. Maybe the ci is blocking some ports?

[ademariag]

Have these tests ever worked? As in connecting to a container?

[MatteoVoges]

Yeah, they did. And for some reason for some commits they still work. I don't have any clue what causes them to fail, because locally everything works fine

[ademariag]

Yeah, they did. And for some reason for some commits they still work. I don't have any clue what causes them to fail, because locally everything works fine

I think I fixed it. the issue is that "container == running" is not the same as vault being able to receive a connection.

So I have added a try-catch