chore: bump Dockerfile golang version to 1.20 #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademariag
approved these changes
Sep 15, 2023
|
It seems that the building CI is a bit flaky, but it works. |
|
@ademariag it seems that nothing happened even with auto-merge (maybe because of skipped tests I don't know). |
As specified by the golang [release policy](https://go.dev/doc/devel/release#policy), "each major go release is supported until there are two newer major releases", which mean that the oldest supported version is currently go 1.20.
|
Thanks for the review ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As specified by the golang release policy, "each major go release is supported until there are two newer major releases", which mean that the oldest supported version is currently go 1.20.
I propose we upgrade the golang version used in the Dockerfile to build go-jsonnet to go 1.20.7 (but we could switch to go 1.21.0 as well if preferred).