fixed Great Weapon Fighting, Great Weapon Master and Polearm Master … #1180
+58
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to work as per 2024 rules added support gwf for fighting style added support gwf for feat added support for gwf in additional damages added support for gwf and gwm for polearm master Pole Strike
dmportella
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to work as per 2024 rules
added support gwf for fighting style
added support gwf for feat
added support for gwf in additional damages
added support for gwf and gwm for polearm master Pole Strike
fixed ability and saving throw pane selection since there were changes to the panes by dndbeyond
Great weapon Fighting as per 2024 rules works like elemental adept where each die can only role a minimum of 3
which is different from 2014 which was reroll 1s and 2s.
i had to mark the difference between them and also review other cases like Great Weapon master and Polearm Master which work differently in 2024
now all cases, GWF applies to all damages including additional damages like the frostbrand extra cold damage
Polearm Master changed the action name to "Pole Strike" from the old Polearm Master ones, so patched that and made it work with GWF and GWM
everything has been tested with all crit rules, common, magical weapons and cantrip damages like booming blade etc.
Mind you GWF as per old ways does not apply to booming blade but if it applies to the additional damages i think should apply to it too, but i have not made that change. everything is per existing functionality (besides the core rules changes on the styles)