Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Fix display of ACLs with leading/trailing spaces in table #591

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

polegkashti
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
I added the CSS rule white-space: pre; to the table cell styling to ensure that ACLs with leading or trailing spaces are displayed correctly. This ensures that spaces are preserved in the UI, reflecting the actual data stored in Kafka.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@polegkashti polegkashti requested a review from a team as a code owner October 8, 2024 17:48
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 8, 2024
@polegkashti
Copy link
Contributor Author

Fixes #590

@Haarolean Haarolean linked an issue Oct 8, 2024 that may be closed by this pull request
4 tasks
@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working area/acl hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved and removed status/triage/manual Manual triage in progress labels Oct 8, 2024
@Haarolean Haarolean changed the title Fix: display of ACLs with leading/trailing spaces in table FE: Fix display of ACLs with leading/trailing spaces in table Oct 8, 2024
@Haarolean Haarolean merged commit 4e2cee7 into kafbat:main Oct 9, 2024
46 of 48 checks passed
@Haarolean
Copy link
Member

@polegkashti thank you for your contribution!
Btw, your git user email looks invalid, PTAL :-) (git config user.email)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/acl hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACL: ACLs with leading/trailing spaces in principal names not shown in table
2 participants