Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: Support Azure Entra (Event Hub with Kafka Protocol) #530

Merged
merged 12 commits into from
Sep 18, 2024
Merged

Auth: Support Azure Entra (Event Hub with Kafka Protocol) #530

merged 12 commits into from
Sep 18, 2024

Conversation

tnewman-at-gm
Copy link
Contributor

@tnewman-at-gm tnewman-at-gm commented Aug 26, 2024 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Azure Event Hub provides Kafka protocol compatibility. This PR adds Azure Entra support to allow Kafka UI to authenticate with Event Hub with Kafka protocol using Azure Entra credentials.

Is there anything you'd like reviewers to focus on?
New Azure Entra classes and changes to the SASL configuration options on the front end.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary) - Created an Event Hub in the Premium Tier with Kafka Enabled. Verified sending and receiving messages.
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES) - Yes, check out Azure Entra Support ui-docs#18
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
image

@tnewman-at-gm tnewman-at-gm requested review from a team as code owners August 26, 2024 12:54
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Aug 26, 2024
github-actions[bot]
github-actions bot reviewed Aug 26, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi tnewman-at-gm! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@tnewman-at-gm tnewman-at-gm mentioned this pull request Aug 26, 2024
Merged
@Haarolean Haarolean requested review from germanosin and a team August 26, 2024 14:42
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes area/auth App authentication related issues and removed status/triage/manual Manual triage in progress labels Aug 26, 2024
germanosin
germanosin approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@germanosin germanosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for contribution

@tnewman-at-gm
Copy link
Contributor Author

This looks great! Thanks for contribution

Thank you. @Haarolean made some very good feedback on this PR, so I will make those updates within the next day or two.

@tnewman-at-gm
Copy link
Contributor Author

This looks great! Thanks for contribution

Thank you. @Haarolean made some very good feedback on this PR, so I will make those updates within the next day or two.

Updated based on feedback

@Haarolean Haarolean self-requested a review August 28, 2024 09:02
@Haarolean Haarolean added the scope/frontend Related to frontend changes label Aug 28, 2024
@Haarolean Haarolean self-assigned this Aug 29, 2024
@tnewman-at-gm
Copy link
Contributor Author

@Haarolean, I addressed all of your comments. Can you take a look again?

@Haarolean Haarolean added this to the 1.1 milestone Sep 18, 2024
@Haarolean Haarolean changed the title FE/BE - Azure Entra Support (Event Hub with Kafka Protocol) Auth: Support Azure Entra (Event Hub with Kafka Protocol) Sep 18, 2024
@Haarolean Haarolean merged commit 04d15b3 into kafbat:main Sep 18, 2024
17 of 18 checks passed
@Haarolean
Copy link
Member

@tnewman-at-gm thanks for your contribution!

@tnewman-at-gm tnewman-at-gm deleted the Feature/Azure-entra branch September 18, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@germanosin germanosin germanosin approved these changes

@Haarolean Haarolean Haarolean approved these changes

Assignees

@Haarolean Haarolean

Labels
area/auth App authentication related issues scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
Release 1.1
Status: Done
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tnewman-at-gm @Haarolean @germanosin