-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE: KC: Bulk operations for connectors #335
Draft
Nilumilak
wants to merge
4
commits into
main
Choose a base branch
from
feature/bulk_operations_connectors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+443
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Added Pause button to the ActionsCell (before you could only Resume) - chevronDownIcon color was fixed
Nilumilak
added
type/enhancement
En enhancement/improvement to an already existing feature
scope/frontend
Related to frontend changes
status/triage/completed
Automatic triage completed
area/connect
Kafka Connect, its connectors
labels
May 1, 2024
kapybro
bot
added
status/triage
Issues pending maintainers triage
status/triage/manual
Manual triage in progress
and removed
status/triage
Issues pending maintainers triage
labels
May 1, 2024
Haarolean
changed the title
Bulk operations for connectors
FE: KC: Bulk operations for connectors
May 1, 2024
Mgrdich
reviewed
May 2, 2024
confirm(confirmMessage, async () => { | ||
try { | ||
await Promise.all( | ||
selectedConnectors.map(({ connect, name }) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Haarolean can we have an endpoint for this that does bulk delete so we don't need to do this multiple promises here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we sure can do that
Haarolean
added
the
hacktoberfest-accepted
PRs accepted towards hacktoberfest goal and will be counted as approved
label
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connect
Kafka Connect, its connectors
hacktoberfest-accepted
PRs accepted towards hacktoberfest goal and will be counted as approved
scope/frontend
Related to frontend changes
status/triage/completed
Automatic triage completed
type/enhancement
En enhancement/improvement to an already existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
resolves #221
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)