Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Sanitize connection.uri for mongo #285

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

gaurav7261
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@gaurav7261 gaurav7261 requested a review from a team as a code owner April 11, 2024 09:13
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Apr 11, 2024
@gaurav7261
Copy link
Contributor Author

@freeformz can you please review

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi gaurav7261! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes and removed status/triage/manual Manual triage in progress labels Apr 11, 2024
@Haarolean Haarolean added this to the 1.1 milestone Apr 11, 2024
@Haarolean Haarolean self-assigned this Apr 11, 2024
@Haarolean
Copy link
Member

@gaurav7261 thanks for your contribution!

@Haarolean Haarolean changed the title [FIX] sanitize connection.uri for mongo BE: Sanitize connection.uri for mongo Apr 11, 2024
@Haarolean Haarolean added type/chore Boring stuff, could be refactoring or tech debt and removed type/enhancement En enhancement/improvement to an already existing feature labels Apr 11, 2024
@Haarolean Haarolean merged commit 4a3c424 into kafbat:main Apr 11, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants