Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Packages housekeeping #265

Merged
merged 2 commits into from
Apr 15, 2024
Merged

FE: Packages housekeeping #265

merged 2 commits into from
Apr 15, 2024

Conversation

Mgrdich
Copy link
Contributor

@Mgrdich Mgrdich commented Apr 4, 2024 •
edited by Haarolean
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Resolves #264

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Mgrdich Mgrdich added the scope/frontend Related to frontend changes label Apr 4, 2024
@Mgrdich Mgrdich self-assigned this Apr 4, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Apr 4, 2024
@Mgrdich Mgrdich force-pushed the chore/house_keeping_packages branch 2 times, most recently from 25b38a9 to be4675c Compare April 14, 2024 20:27
@Mgrdich Mgrdich marked this pull request as ready for review April 15, 2024 09:27
@Mgrdich Mgrdich requested a review from a team as a code owner April 15, 2024 09:27
@Mgrdich Mgrdich force-pushed the chore/house_keeping_packages branch from 0c53948 to 3afd8c4 Compare April 15, 2024 09:28
@Mgrdich
Sanitise Dependencies remove unwanted ones.
a585238 
Fix the dependencies and dev dependencies to reflect actually what is what.

move fetchwmg for testing and fetchmock to dev dependencies

nanoid code replacement, schema code replacement fixes.

add delete Schema hook.

add invalidation + typescript typing to the custom query schemas hooks.

Replace redux schema instances

Migrate Diff of the Schema to use React query

Pages Fixes and retaining old functionalities

Remove Schema code reducers + Fix all the tests for Schema + add TODO comments for missing functionalities

Nuke All redux related code

Redux package deprication

TopicForm import fix

Fix eslint bugs

Add hook tests suites for schemas
@Mgrdich Mgrdich force-pushed the chore/house_keeping_packages branch from 3afd8c4 to a585238 Compare April 15, 2024 09:30
@Mgrdich Mgrdich added this to the 1.1 milestone Apr 15, 2024
@Haarolean Haarolean self-assigned this Apr 15, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Haarolean Haarolean added type/chore Boring stuff, could be refactoring or tech debt dependencies and removed status/triage/manual Manual triage in progress labels Apr 15, 2024
@Haarolean Haarolean changed the title Chore/house keeping packages FE: Packages housekeeping Apr 15, 2024
@Haarolean Haarolean merged commit 3fdbfba into main Apr 15, 2024
26 checks passed
@Haarolean Haarolean deleted the chore/house_keeping_packages branch April 15, 2024 13:45
@Haarolean Haarolean added type/dependencies A pull request/issue dedicated to updating the dependency(-ies) and removed dependencies labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Haarolean approved these changes

Assignees

@Haarolean Haarolean

@Mgrdich Mgrdich

Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt type/dependencies A pull request/issue dedicated to updating the dependency(-ies)
Projects
Release 1.1
Status: Done
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

FE: Housekeeping frontend libraries
2 participants
@Mgrdich @Haarolean