Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Redesign menu #227

Merged
merged 19 commits into from
Apr 30, 2024
Merged

FE: Redesign menu #227

merged 19 commits into from
Apr 30, 2024

Conversation

Leshe4ka
Copy link
Contributor

Resolve #195

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Leshe4ka Leshe4ka added scope/frontend Related to frontend changes type/refactor Refactoring task area/ux User experiense issues labels Mar 19, 2024
@Leshe4ka Leshe4ka self-assigned this Mar 19, 2024
@Leshe4ka Leshe4ka requested a review from a team as a code owner March 19, 2024 02:38
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 19, 2024
@Haarolean Haarolean removed the status/triage/manual Manual triage in progress label Mar 25, 2024
@Leshe4ka
Copy link
Contributor Author

review pls

@Haarolean Haarolean requested a review from Mgrdich March 30, 2024 13:17
@Haarolean Haarolean assigned Haarolean and unassigned Leshe4ka Apr 19, 2024
@Haarolean Haarolean self-requested a review April 19, 2024 11:06
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite broken with the light theme:
image

@Leshe4ka Leshe4ka requested a review from Haarolean April 24, 2024 06:55
@Leshe4ka
Copy link
Contributor Author

Quite broken with the light theme: image

Resolved

@Leshe4ka Leshe4ka self-assigned this Apr 24, 2024
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed a fix for the status icon size, the rest seems to be good, thanks

@Leshe4ka Leshe4ka requested a review from a team as a code owner April 30, 2024 09:09
@Haarolean Haarolean merged commit fcb007c into main Apr 30, 2024
12 of 13 checks passed
@Haarolean Haarolean deleted the kafbat/195 branch April 30, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux User experiense issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/refactor Refactoring task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Redesign menu
4 participants