Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: UX: Update color palette #158

Merged
merged 3 commits into from
Mar 1, 2024
Merged

FE: UX: Update color palette #158

merged 3 commits into from
Mar 1, 2024

Conversation

Haarolean
Copy link
Member

@Haarolean Haarolean commented Feb 21, 2024

Update brand colors. Update favicon and logo. Fix hardcoded & wrong colors, fix logo size.
Closes #64

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean self-assigned this Feb 21, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage area/ux User experiense issues status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 21, 2024
@Haarolean Haarolean added scope/frontend Related to frontend changes type/chore Boring stuff, could be refactoring or tech debt labels Feb 21, 2024
Copy link
Contributor

@Mgrdich Mgrdich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expect(within(header).getByText('Kafbat UI')).toBeInTheDocument();

test should be changed to incorporate the changed text which was lower case

@Haarolean Haarolean requested a review from Mgrdich March 1, 2024 13:58
@Haarolean Haarolean merged commit 3608b26 into main Mar 1, 2024
4 of 8 checks passed
@Haarolean Haarolean deleted the issues/64 branch March 1, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux User experiense issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color palette
2 participants