FE: Build fix, add tsc to build goal (#191)

kafbat · Mar 7, 2024 · b3691ce · b3691ce
1 parent 6ad30a3
commit b3691ce
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/.github/workflows/frontend_tests.yml b/.github/workflows/frontend_tests.yml
@@ -13,37 +13,45 @@ jobs:
       NODE_ENV: dev
     runs-on: ubuntu-latest
     steps:
+
       - uses: actions/checkout@v4
         with:
           # Disabling shallow clone is recommended for improving relevancy of reporting
           fetch-depth: 0
           ref: ${{ github.event.pull_request.head.sha }}
           token: ${{ github.token }}
+
       - uses: pnpm/[email protected]
         with:
           version: 8.6.12
+
       - name: Install node
         uses: actions/[email protected]
         with:
           node-version: "18.17.1"
           cache: "pnpm"
           cache-dependency-path: "./frontend/pnpm-lock.yaml"
+
       - name: Install Node dependencies
         run: |
           cd frontend/
           pnpm install --frozen-lockfile
-      - name: Generate sources
+
+      - name: Compile
         run: |
           cd frontend/
-          pnpm gen:sources
+          pnpm compile
+
       - name: Linter
         run: |
           cd frontend/
           pnpm lint:CI
+
       - name: Tests
         run: |
           cd frontend/
           pnpm test:CI
+
       - name: SonarCloud Scan
         if: false # TODO remove when public
         uses: sonarsource/sonarcloud-github-action@master

diff --git a/frontend/package.json b/frontend/package.json
@@ -51,8 +51,9 @@
     "start": "vite",
     "dev": "vite",
     "clean": "rimraf ./src/generated-sources",
+    "compile": "pnpm gen:sources && tsc --noEmit",
     "gen:sources": "pnpm clean && openapi-generator-cli generate",
-    "build": "pnpm gen:sources && tsc --noEmit && vite build",
+    "build": "pnpm compile && vite build",
     "preview": "vite preview",
     "lint": "eslint --ext .tsx,.ts src/",
     "lint:fix": "eslint --ext .tsx,.ts src/ --fix",

diff --git a/frontend/src/components/common/NewTable/__test__/Table.spec.tsx b/frontend/src/components/common/NewTable/__test__/Table.spec.tsx
@@ -94,7 +94,7 @@ const columns: ColumnDef<Datum>[] = [
 
 const ExpandedRow: React.FC = () => <div>I am expanded row</div>;
 
-interface Props extends TableProps<Datum, Datum> {
+interface Props extends TableProps<Datum> {
   path?: string;
 }