Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rails to 6 #79

Merged
merged 34 commits into from
Oct 29, 2024
Merged

Upgrade rails to 6 #79

merged 34 commits into from
Oct 29, 2024

Conversation

matthijsgroen
Copy link
Member

What

Explain what changes inside the code, this can be as simple or complicated as you want as long as it's clear

Why

Explain why these things are changes. This explanation is for your colleagues and your future self.

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • Does the code actually solve the problem it was meant to solve?
  • Is the code covered by unit tests? Integration tests?
  • Does anything here need documentation? (Focus on why, not what.)
  • Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • Is the code easy to understand and change in the future?
  • Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • Does the code reasonably adhere to the Kabisa coding standards?
  • Be kind.

@matthijsgroen matthijsgroen mentioned this pull request Sep 30, 2024
8 tasks
@matthijsgroen
Copy link
Member Author

When running locally, all tests are now green:

docker compose up --build
docker exec -it kudo-o-matic_web bash
RAILS_ENV=test bundle exec rspec
Finished in 13.02 seconds (files took 1.84 seconds to load)
617 examples, 0 failures

@matthijsgroen matthijsgroen marked this pull request as ready for review October 28, 2024 10:46
@Ashhas Ashhas merged commit 4b6eb6e into update-heroku-stack Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants