-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
All the stack guides are updated to reflect Kabanero v0.9.0: kabanero-io/docs#388. In addition, MicroProfile reference in using-appsodi-cli.md is removed: kabanero-io/docs#389 Signed-off-by: Sue Chaplain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found a few instances of a questionable URL
include: | ||
- java-openliberty | ||
image-org: | ||
image-registry: | ||
nginx-image-name: | ||
``` | ||
|
||
This example configuration file builds a single stack hub index file for your `default` hub. The `default` hub points to two index files, `https://github.com/appsody/stacks/releases/latest/download/incubator-index.yaml` and `https://github.com/kabanero-io/collections/releases/download/0.6.0/kabanero-index.yaml`. The `include:` and `exclude:` options are used | ||
This example configuration file builds a single stack hub index file for your `default` hub. The `default` hub points to two index files, `https://github.com/appsody/stacks/releases/latest/download/incubator-index.yaml` and `https://github.com/kabanero-io/collections/releases/download/0.9.0/kabanero-index.yaml`. The `include:` and `exclude:` options are used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the /collections URL isn't used anymore, this is the new format:
https://github.com/kabanero-io/kabanero-stack-hub/releases/download/0.9.0/kabanero-stack-hub-index.yaml
might need to do a global search in guides for this URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is confusing, but if you look at the kabanero-stack-hub-index.yaml
file, it still points to https://github.com/kabanero-io/collections/releases/download/0.9.0/kabanero-index.yaml
.
The kabanero-stack-hub-index.yaml
file is effectively what Steve and Matt generate with the process that this guide covers, so my thinking was that it should remain with the older URL for now ... that URL looks like it is still being generated for the 0.9.0 release. See https://github.com/kabanero-io/collections/releases/tag/0.9.0-rc.1.
@groeges or @kilnerm - are the updates I made for this guide ok this time around? i.e. guide combines appsody latest
stacks with kabanero 0.9.0
stacks to generate a stack-hub yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification @SueChaplain . I'll approve as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jantley-ibm This config is what is used to generate the kabanero-stack-hub-index.yaml, so the URL cannot point to itself. The stacks are still coming from the Kabanero Collections repo as well as the Appsody repo to generate the consolidated index. We will need to continue using the collections repo until the certified stacks repo is available (now delayed to 3Q).
@@ -163,7 +163,7 @@ Checking stack requirements... | |||
Appsody requirements met | |||
Docker requirements met | |||
Running appsody init... | |||
Downloading java-openliberty template project from https://github.com/kabanero-io/collections/releases/download/0.6.4/java-openliberty.v0.2.3.templates.default.tar.gz | |||
Downloading java-openliberty template project from https://github.com/kabanero-io/collections/releases/download/0.9.0/java-openliberty.v0.2.3.templates.default.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/collections -> /kabanero-stack-hub
@@ -167,20 +167,20 @@ appsody init nodejs-express | |||
The output from the command is similar to the following example: | |||
|
|||
``` | |||
Downloading nodejs-express template project from https://github.com/kabanero-io/collections/releases/download/0.6.4/nodejs-express.v0.2.10.templates.simple.tar.gz | |||
Downloading nodejs-express template project from https://github.com/kabanero-io/collections/releases/download/0.9.0/nodejs-express.v0.4.8.templates.simple.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/collections -> /kabanero-stack-hub
All the stack guides are updated to reflect Kabanero v0.9.0: kabanero-io/docs#388.
In addition, MicroProfile reference in using-appsodi-cli.md is removed: kabanero-io/docs#389
Signed-off-by: Sue Chaplain [email protected]