-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maps.py configurable enter requirements #135
Open
thmsndk
wants to merge
10
commits into
kaansoral:main
Choose a base branch
from
thmsndk:feature/configurable-enter-requirements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
maps.py configurable enter requirements #135
thmsndk
wants to merge
10
commits into
kaansoral:main
from
thmsndk:feature/configurable-enter-requirements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsndk
force-pushed
the
feature/configurable-enter-requirements
branch
from
July 27, 2024 20:33
a396eea
to
f56650e
Compare
Telokis
reviewed
Aug 13, 2024
Telokis
reviewed
Aug 13, 2024
Telokis
added
Type: enhancement
Changes the existing content of the game
Scope: game server
The game server is impacted
Status: waiting for author
The maintainers are waiting for the author or contributor to reply or perform changes
Scope: meta
This relates to the repository, code, or environment without meaningful direct impact to the game
labels
Aug 13, 2024
thmsndk
force-pushed
the
feature/configurable-enter-requirements
branch
from
August 13, 2024 20:57
f56650e
to
8ecfa1b
Compare
…uplicate itemKeys
thmsndk
force-pushed
the
feature/configurable-enter-requirements
branch
from
August 14, 2024 08:59
8ecfa1b
to
aad9a19
Compare
@Telokis should be ready for review again |
Telokis
added
Status: waiting for review
This PR is waiting for a maintainer to review it
and removed
Status: waiting for author
The maintainers are waiting for the author or contributor to reply or perform changes
labels
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Scope: game server
The game server is impacted
Scope: meta
This relates to the repository, code, or environment without meaningful direct impact to the game
Status: waiting for review
This PR is waiting for a maintainer to review it
Type: enhancement
Changes the existing content of the game
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
crypt
andwinter_instance
is hardcoded in thesocket.on("enter")
event, this change allows us to configure it instead of having to hardcode each new instance. I have verified that the correct key is still required and you still need to be near the correct doorThis is also something that is used in the bee dungeon I'm working on. Figured it would make sense with a smaller PR only containing this change.
A future extension could be
class
orlevel
requirements to enable class specific instances or min/max levels.Engine Enhancements
.enter
requirements in maps.py.enter.items
is an object the item required as the key and the amount required as the values, multiple items and their quantity required can be specifiedenter.locations
is an array of tuples with a list of locations where you have to be near one of them to enter, this could also allow you to enter the instance from different doors leading to different spawn points.