Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/client formatting linting #132

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

thmsndk
Copy link
Contributor

@thmsndk thmsndk commented Apr 20, 2024

Adds eslint and prettier to the js folder

image

I would also like to add eslint/prettier to the htmls folder that python servers, but i'm not sure how to do that and if it is a good idea. it is not normal html, it uses a python library to process the html and replace variables

@Telokis
Copy link
Collaborator

Telokis commented Apr 21, 2024

Big undertaking.

I think it's a good opportunity to also add the rule prefer-template.

@thmsndk
Copy link
Contributor Author

thmsndk commented Apr 21, 2024

I can look into adding prefer-template

I was also strongly considering configuring newlines for certain places https://eslint.style/rules/js/padding-line-between-statements (this seems to be latest version, and requires some upgrading to @stylistic/eslint-plugin-js.) it makes the code way more readable imho.

@Telokis Telokis added Scope: Game client Relates to the client code Type: enhancement Changes the existing content of the game Scope: meta This relates to the repository, code, or environment without meaningful direct impact to the game labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Game client Relates to the client code Scope: meta This relates to the repository, code, or environment without meaningful direct impact to the game Type: enhancement Changes the existing content of the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants