Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add feature gates to our readme #756

Merged

Conversation

tobiasgiese
Copy link
Contributor

@tobiasgiese tobiasgiese commented Aug 12, 2024

This PR adds a feature gates section to our README.
Depends on #733

Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@tobiasgiese tobiasgiese force-pushed the add-featuregates-readme branch 2 times, most recently from b7931d0 to f3b84a5 Compare August 12, 2024 09:48
@coveralls
Copy link

coveralls commented Aug 12, 2024

Pull Request Test Coverage Report for Build 10350466058

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 45.161%

Totals Coverage Status
Change from base Build 10318797846: 0.007%
Covered Lines: 6528
Relevant Lines: 14455

💛 - Coveralls

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, overall LGTM

@tobiasgiese
Copy link
Contributor Author

tobiasgiese commented Aug 12, 2024

We should wait until #733 is merged IMO

@SchSeba SchSeba merged commit 66247d0 into k8snetworkplumbingwg:master Aug 12, 2024
13 checks passed
@tobiasgiese tobiasgiese deleted the add-featuregates-readme branch August 12, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants