[metrics 4/x] Metrics exporter rules #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
metrics-exporter-rules
branch
from
e1551a6
to
86719de
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
metrics-exporter-rules
branch
from
86719de
to
0069e5e
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
metrics-exporter-rules
branch
from
0069e5e
to
fed3f8c
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
metrics-exporter-rules
branch
from
fed3f8c
to
5ba65f8
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
metrics-exporter-rules
branch
from
5ba65f8
to
5b085ea
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
metrics-exporter-rules
branch
4 times, most recently
from
3eced4d
to
7b25cc6
Compare
zeeke
force-pushed
the
metrics-exporter-rules
branch
from
7b25cc6
to
f004d91
Compare
Pull Request Test Coverage Report for Build 10903994186Details
💛 - Coveralls |
bindata/manifests/metrics-exporter/metrics-prometheus-rule.yaml
Outdated
Show resolved
Hide resolved
zeeke
force-pushed
the
metrics-exporter-rules
branch
3 times, most recently
from
d8ce5ef
to
9493e50
Compare
| @@ -29,6 +29,7 @@ rules: | |||
| - monitoring.coreos.com | |||
| resources: | |||
| - servicemonitors | |||
| - prometheusrules | |||
There was a problem hiding this comment.
Do we support deletion of prometheus objects ?
There was a problem hiding this comment.
For when sno is redeployed with prometheus disabled (e.g in helm chart)
There was a problem hiding this comment.
good point. we have to support object deletion as well. I handle it in
- metrics: Add permissions to remove monitor objects #769
but it's better to merge that changes into these PR.
|
@adrianchiris can we move this forward? |
Eoghan1232
reviewed
Sep 17, 2024
PrometheusRules allow recording pre-defined queries. Use `sriov_kubepoddevice` metric to add `pod|namespace` pair to the sriov metrics. Feature is enabled via the `METRICS_EXPORTER_PROMETHEUS_DEPLOY_RULE` environment variable. Signed-off-by: Andrea Panattoni <[email protected]>
When the `metricsExporter` feature is turned off, deployed resources
should be removed. These changes fix the error:
```
│ 2024-08-28T14:07:57.699760017Z ERROR controller/controller.go:266 Reconciler error {"controller": "sriovoperatorconfig", "controllerGroup": "sriovnetwork.openshift.io", "controllerKind": "SriovOperatorConfig", "SriovOperatorConfig": {"name":"default","namespace":"openshift-sriov-network-operator"}, │
│ "namespace": "openshift-sriov-network-operator", "name": "default", "reconcileID": "fa841c50-dbb8-4c4c-9ddd-b98624fd2a24", "error": "failed to delete object &{map[apiVersion:monitoring.coreos.com/v1 kind:ServiceMonitor metadata:map[name:sriov-network-metrics-exporter namespace:openshift-sriov-network-operator] │
│ spec:map[endpoints:[map[bearerTokenFile:/var/run/secrets/kubernetes.io/serviceaccount/token honorLabels:true interval:30s port:sriov-network-metrics scheme:https tlsConfig:map[caFile:/etc/prometheus/configmaps/serving-certs-ca-bundle/service-ca.crt insecureSkipVerify:false serverName:sriov-network-metrics-expor │
│ ter-service.openshift-sriov-network-operator.svc]]] namespaceSelector:map[matchNames:[openshift-sriov-network-operator]] selector:map[matchLabels:map[name:sriov-network-metrics-exporter-service]]]]} with err: could not delete object (monitoring.coreos.com/v1, Kind=ServiceMonitor) openshift-sriov-network-operato │
│ r/sriov-network-metrics-exporter: servicemonitors.monitoring.coreos.com \"sriov-network-metrics-exporter\" is forbidden: User \"system:serviceaccount:openshift-sriov-network-operator:sriov-network-operator\" cannot delete resource \"servicemonitors\" in API group \"monitoring.coreos.com\" in the namespace \"ope │
│ nshift-sriov-network-operator\""}
```
Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
metrics-exporter-rules
branch
from
504ce7d
to
b49cf15
Compare
Eoghan1232
approved these changes
Sep 17, 2024
zeeke
added a commit
to zeeke/sriov-network-operator
that referenced
this pull request
Sep 20, 2024
Make the operator creating PrometheusRules to browse metrics in the Developer Console. refs: - k8snetworkplumbingwg/sriov-network-operator#732 Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
added a commit
to zeeke/sriov-network-operator
that referenced
this pull request
Sep 20, 2024
Make the operator creating PrometheusRules to browse metrics in the Developer Console. refs: - k8snetworkplumbingwg/sriov-network-operator#732 Signed-off-by: Andrea Panattoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrometheusRules allow recording pre-defined queries. Use
sriov_kubepoddevicemetric to addpod|namespacepairto the sriov metrics.
Here is an example of the raw exported metrics:
Proposed prometheus rules allow to query the following new metrics:
network:sriov_vf_tx_packetsnetwork:sriov_vf_rx_packetsnetwork:sriov_vf_tx_bytesnetwork:sriov_vf_rx_bytesnetwork:sriov_vf_tx_droppednetwork:sriov_vf_rx_droppednetwork:sriov_vf_rx_broadcastnetwork:sriov_vf_rx_multicast