Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove Default Objs 3/4] Remove default policy #622

Merged
merged 2 commits into from
Feb 20, 2024
Merged

[Remove Default Objs 3/4] Remove default policy #622

merged 2 commits into from
Feb 20, 2024

Conversation

adrianchiris
Copy link
Collaborator

There is no need to create it anymore

This PR depends on #621 , only the last commit is relevant, the rest will be rebased away

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Feb 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7960380880

Details

  • -18 of 26 (30.77%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 34.476%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/helper.go 5 9 55.56%
controllers/sriovnetworknodepolicy_controller.go 3 17 17.65%
Files with Coverage Reduction New Missed Lines %
controllers/sriovnetworknodepolicy_controller.go 2 20.59%
Totals Coverage Status
Change from base Build 7959871224: 0.07%
Covered Lines: 4134
Relevant Lines: 11991
💛 - Coveralls

@adrianchiris
Copy link
Collaborator Author

Related to: #592

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris adrianchiris mentioned this pull request Feb 7, 2024
Merged
@adrianchiris adrianchiris changed the title Remove default policy [Remove Default Objs 3/4] Remove default policy Feb 8, 2024
ykulazhenkov
ykulazhenkov reviewed Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no comments, LGTM after rebase

@adrianchiris
Remove the creation of default SriovNetworkNodePolicy
dc8c040 
There is no need to create it anymore.

Signed-off-by: adrianc <[email protected]>
@adrianchiris
Send intial sync event to sriovnetworknodepolicy controller
74729fa 
Since default policy is not created by operator we should trigger
an initial reconcile to allow the creation of sriovnetworknodestate
objects as webhook uses these objects to validate policy.

Signed-off-by: adrianc <[email protected]>
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris adrianchiris requested review from ykulazhenkov and zeeke and removed request for ykulazhenkov February 19, 2024 13:32
SchSeba
SchSeba reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment.

controllers/sriovnetworknodepolicy_controller.go Show resolved Hide resolved
SchSeba
SchSeba approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work

@adrianchiris adrianchiris merged commit 5fcd26d into k8snetworkplumbingwg:master Feb 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykulazhenkov ykulazhenkov ykulazhenkov approved these changes

@SchSeba SchSeba SchSeba approved these changes

@zeeke zeeke Awaiting requested review from zeeke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianchiris @coveralls @SchSeba @ykulazhenkov