Add metadata to Docker images #540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 6788278066
💛 - Coveralls |
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
bn222
reviewed
Nov 7, 2023
For troubleshooting it's useful to have following data: * image build time * git branch * git revision Also this commits modifies 'make image' target to build webhook image too.
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
LGTM |
adrianchiris
reviewed
Nov 9, 2023
| @@ -12,8 +12,15 @@ export OPERATOR_EXEC?=oc | |||
| BUILD_GOPATH=$(TARGET_DIR):$(TARGET_DIR)/vendor:$(CURPATH)/cmd | |||
| IMAGE_BUILDER?=docker | |||
| IMAGE_BUILD_OPTS?= | |||
| IMAGE_METADATA=--build-arg BUILD_DATE="$(BUILD_TIMESTAMP)" --build-arg VERSION="$(BUILD_VERSION)" --build-arg VCS_REF="$(VCS_REF)" --build-arg VCS_BRANCH="$(VCS_BRANCH)" | |||
There was a problem hiding this comment.
this works ? values of those vars are only set below.
There was a problem hiding this comment.
In that sense, I suggest to update how images are built for end-to-end tests:
This way we can see it in CI
There was a problem hiding this comment.
+1 lets do the same build as part of the CI
|
@e0ne you still planning to work on this one ? |
|
We don't need this PR anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For troubleshooting it's useful to have following data:
Also this commits modifies 'make image' target to build webhook image too.