Add support for Intel E823C NICs #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use Kontron ME1310 Edge Servers which has built in E823C NICs. We create VFs using these NICs. We are able to create SriovNetworkNodePolicy and create the VFs after adding it under supported-nic-ids config map
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
@Eoghan1232 does intel support this nic in the sriov operator? |
SchSeba
reviewed
Oct 17, 2023
let me check, I've never used this specific nic before, but I can see it being used in DPDK and other docs. if @murali509 confirms the functionality and fixes the PR, I see no reason to object. |
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Hi @Eoghan1232, we have tested sriov functionality on this Intel E823-C NIC in Kontron ME1310 servers and its working fine. |
|
|
|
|
kubectl -n gke-operators get SriovNetworkNodeState dauk-mrl-k-gdcv-host02.denseair.net -o yaml
|
Pull Request Test Coverage Report for Build 6549752628
💛 - Coveralls |
|
@SchSeba @Eoghan1232 , I don't have idea why some check failed in OCP. I don't think the code change is related to the failed test in ocp. Could you help to let me know what can be done further? |
Eoghan1232
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
I'm okay with these changes, @murali509 can you confirm you tested binding the VF's to a DPDK driver too? I see you marked it as capable in the PR.
Yes I have tested binding the VFs to a DPDK driver as you can see the output for eno2 NIC (E823C) below with vfio-pci type: kubectl -n gke-operators get SriovNetworkNodeState dauk-mrl-k-gdcv-host02.denseair.net -o yaml
|
adrianchiris
approved these changes
Oct 19, 2023
|
please create an issue for tracking so we can close once this is merged. |
|
Could you help to merge into master if there are no further review comments? |
|
HI @murali509 just waiting for the issue so we can merge and close the issue together thanks! |
|
@SchSeba, issue was opened previously #501 (comment) |
SchSeba
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Kontron ME1310 Edge Servers which has built in E823C NICs. We create VFs using these NICs. We are able to create SriovNetworkNodePolicy and create the VFs after adding it under supported-nic-ids config map