e2e: Fix Validate ExcludeTopology test leftover

[zeeke]

Fix coding errors introduced while refactoring

• conformance-test: ExcludeTopology field #451

cc @adrianchiris

[github-actions]

Thanks for your PR,
To run vendors CIs use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[coveralls]

Pull Request Test Coverage Report for Build 5646836853

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.06%) to 24.511%

---

Totals
Change from base Build 5645891211:	0.06%
Covered Lines:	2082
Relevant Lines:	8494

---

💛 - Coveralls

[zeeke]

@adrianchiris , @SchSeba, unfortunately I left over some errors during my last push on previous PR.

Can you please take a look at this?

Sorry for the inconvenience

[e0ne]

@zeeke can we get some CI results before merging this?

[zeeke]

Hi @e0ne, we are working to run this test suite closer to this repository, but we're still hitting some virtualization challenges.

Attached are reports of running make test-e2e-conformance against an OpenShift 4.13 cluster, on master and pr branch, focusing on ExcludeTopology testcases

master.output.txt
master_unit_report.xml.txt
pr.output.txt
pr_unit_report.xml.txt

This PR fixes

• [FAILED] [77.393 seconds]
[sriov] operator Custom SriovNetworkNodePolicy Configuration ExcludeTopology [It] field is forwarded to the device plugin configuration
/home/apanatto/dev/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1444

  [FAILED] Timed out after 30.000s.
  Expected
      <map[string]string | len:2>: {
          "dhcp19-17-171.clus2.t5g.lab.eng.bos.redhat.com": "{\"resourceList\":null}",
          "cnfdd5.clus2.t5g.lab.eng.bos.redhat.com": "{\"resourceList\":[{\"resourceName\":\"resourceXXX\",\"selectors\":{\"pfNames\":[\"eno2np1#0-4\"],\"IsRdma\":false,\"NeedVhostNet\":false},\"SelectorObj\":null}]}",
      }
  to have {key: value} matching
      <map[interface {}]interface {} | len:1>: {
          <string>"cnfdd5.clus2.t5g.lab.eng.bos.redhat.com": <*matchers.ContainSubstringMatcher | 0xc000874ba0>{
              Substr: "{\"resourceName\":\"resourceXXX\",\"excludeTopology\":true,\"selectors\":{\"pfNames\":[\"eno2np1#0-4\"],\"IsRdma\":false,\"NeedVhostNet\":false},\"SelectorObj\":null}",
              Args: nil,
          },
      }
  In [It] at: /home/apanatto/dev/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:2244 @ 08/02/23 10:08:37.741

[e0ne]

@zeeke thanks for the information!