Improve operator logging #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set a TimeEncoder for zap logging system to have more speaking timestamp. from `1.6893201844680622e+09` to `2023-07-14T09:52:29.539392293Z` Signed-off-by: Andrea Panattoni <[email protected]>
In `renderDevicePluginConfigData()`, avoid logging the full ResourceList for every resource in the loop. Avoid logging in helper functions, as they can be invoked in loops. Signed-off-by: Andrea Panattoni <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 5554171225
💛 - Coveralls |
|
lgtm |
|
We are using a mix of different loggers. I see there is also |
adrianchiris
approved these changes
Jul 20, 2023
we should definitely have a consistency with logging across different components in the operator. perhaps create an issue about it ? LGTM, merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the logging system of the operator:
a.
sigs.k8s.io/controller-runtime/pkg/log/zaplogging system needs a TimeEncoder to be set, so log lines change from:to
b. Avoid logging in helper functions
c.
renderDevicePluginConfigData()was logging a growing ResourceList array in a loop, leading to excessive logging when the cluster has 20+ policies.