Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 471 #474

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix issue 471 #474

merged 1 commit into from
Jul 13, 2023

Conversation

lmilleri
Copy link
Contributor

It fixes a problem with SRIOV/vDPA configuration:

#471

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

SchSeba
SchSeba approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

coveralls commented Jul 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5542031550

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 24.497%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 66.04%
api/v1/helper.go 3 41.67%
controllers/sriovnetwork_controller.go 4 65.71%
Totals Coverage Status
Change from base Build 5541389324: -0.1%
Covered Lines: 2081
Relevant Lines: 8495
💛 - Coveralls

adrianchiris
adrianchiris requested changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmilleri small nit: please update commit msg with the issue and the change.
instead/in-addition of linking to gh issue.

@SchSeba SchSeba mentioned this pull request Jul 13, 2023
Merged
@lmilleri
Fix issue when creating SRIOV/vDPA devices
95eed3f 
Problem: if you apply a policy with vdpa devices, no VFs are created
Solution: make sure all the references to the file sriov_config.json
are correct, since its location has changed

k8snetworkplumbingwg#471

Signed-off-by: Leonardo Milleri <[email protected]>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@lmilleri
Copy link
Contributor Author

Commit message updated. Thanks

adrianchiris
adrianchiris approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! ❤️

@adrianchiris adrianchiris merged commit 52e9d20 into k8snetworkplumbingwg:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lmilleri @coveralls @SchSeba @adrianchiris