Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce config-daemon logging verbosity #468

Merged

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Jul 11, 2023

This PR reduces the verbosity of the config-daemon loop when the user sets a SriovOperatorConfig.Spec.LogLevel < 2.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Jul 11, 2023

Pull Request Test Coverage Report for Build 5658676889

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 24.547%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/utils.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 64.15%
pkg/utils/utils.go 2 6.4%
Totals Coverage Status
Change from base Build 5645891211: 0.09%
Covered Lines: 2086
Relevant Lines: 8498

💛 - Coveralls

@liornoy
Copy link
Contributor

liornoy commented Jul 16, 2023

lgtm

Copy link
Contributor

@cgoncalves cgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Devlink mode is not supported by every SR-IOV NIC model.

Signed-off-by: Andrea Panattoni <[email protected]>
Log `getLinkType(): ...` only if LogLevel == 2

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke force-pushed the improve-config-daemon-logging branch from 7350855 to 9a500dd Compare July 25, 2023 15:21
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants