Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added kubeconfig in analyze request input #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lili-wan
Copy link
Contributor

@lili-wan lili-wan commented Oct 15, 2024

Closes k8sgpt-ai/k8sgpt#1271

📑 Description

we would like to call analyze API on a remote cluster from a central platform. This has been discussed in the k8sgpt channel with Alex, https://k8sgpt.slack.com/archives/C050SKW7SHF/p1728506662655359

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@lili-wan
Copy link
Contributor Author

Hi @AlexsJones , could you please help to take a look at the PR? the error message looks misleading as I did not touch that part of the code and my local build/test has passed, thanks!

@AlexsJones
Copy link
Member

Before we do this @lili-wan I just want to challenge a thought here - Should we be passing the raw kubeconfig like this over rpc or should we point it to another secret in the cluster. WDYT?

@lili-wan
Copy link
Contributor Author

lili-wan commented Oct 29, 2024

Before we do this @lili-wan I just want to challenge a thought here - Should we be passing the raw kubeconfig like this over rpc or should we point it to another secret in the cluster. WDYT?

Hi Alex, thanks for replying the message, yes, for open source that would be more secure. I can update the field to take a secret name and add a namespace name where the secret lives, does that sound good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add kubeconfig option in Analyze API to call a remote cluster Analyze
2 participants