WIP: feat: add minio cache #521
Conversation
Signed-off-by: Shahrooz Aghili <[email protected]>
|
@arbreezy Hi, As an edge case when I use bedrock as the AI provider, client config can not pick up the minio access key and credentials from the cache secret and keeps using the aws_access_key_id and aws_secret_access_key. please see |
| @@ -266,8 +266,15 @@ func GetDeployment(config v1alpha1.K8sGPT, outOfClusterMode bool, c client.Clien | |||
| addRemoteCacheEnvVar("AZURE_TENANT_ID", "azure_tenant_id") | |||
| addRemoteCacheEnvVar("AZURE_CLIENT_SECRET", "azure_client_secret") | |||
| } else if config.Spec.RemoteCache.S3 != nil { | |||
| addRemoteCacheEnvVar("AWS_ACCESS_KEY_ID", "aws_access_key_id") | |||
There was a problem hiding this comment.
Why do we need different env variables although we are using the same aws client, in theory this shouldn't matter if it's s3 native or minio?
Good shout, this happens cause we override the same env variable with the bedrock's secret key which is added later thus overwriting the cache's secret. I think the options are a) we initialise a minio native client b) we use profiles with the latter we need to create files IIRC |
|
I think we should adress the AWS env variables in another PR. The issue exists with s3 as remote cache + bedrock. @aghilish you will have to add the updated CRD in helm templates too |
| if config.Spec.RemoteCache.S3.Endpoint != "" { | ||
| // MinIO | ||
| addRemoteCacheEnvVar("MINIO_ACCESS_KEY", "minio_access_key") | ||
| addRemoteCacheEnvVar("MINIO_SECRET_KEY", "minio_secret_key") |
There was a problem hiding this comment.
We are using the aws s3 client on the k8sgpt side so those secret names won't get picked, up I think
Closes #464
This pull request enables using minio backend as s3 cache alternative.
📑 Description
✅ Checks
ℹ Additional Information