fix lattice length of rnnt_decode #1089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkufool
reviewed
Nov 3, 2022
| states_.TotSize(1), | ||
| config_.vocab_size, | ||
| 0); | ||
| Advance(dummy_logprobs); |
There was a problem hiding this comment.
Current implementation will cause an error when decoding chunk by chunk, I think you need to delete the states gennerated by dummy advance before flushing back to streams.
There was a problem hiding this comment.
I will say, a dummy advance is a good idea to fix this issue.
There was a problem hiding this comment.
BTW, we'd better make this dummy advance run only once per sequence (i.e. the last chunk), If we do it for every chunk, it will be a big overhead.
|
Close this since we figure out a faster verson. #1134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logprobs of final frame does not contribute lattice generation.
This pr is trying to fix this issue.
With original code.
if num_frames = 1
if num_frames = 10
Current pr
if num_frames = 1
if num_frames = 10
